Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Platelink templates #582

Closed
wants to merge 7 commits into from
Closed

Add Platelink templates #582

wants to merge 7 commits into from
+48 −0

Conversation

shubhusion
Copy link
Contributor

Description

Templates for adding a custom domain to a Platelink site, development versions.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Linter OK:

Linter result for platelink.dev.domain.json

@kerolasa
Copy link
Collaborator

I wonder if the two templates could be merged to be a single one that has groupId to separate what gets to be applied.

@kerolasa
Copy link
Collaborator

Also, it would be nice to squash the commits.

@shubhusion shubhusion closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhusion @kerolasa